【不兼容升级】移除paddle.nn.functional.diag_embed，添加paddle.diag_embed并支持作为类方法 #58223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
xuxinyi389
changed the title
|
should delete |
zhwesky2010
approved these changes
Oct 23, 2023
tianshuo78520a
approved these changes
Oct 23, 2023
hitywt
pushed a commit
to hitywt/Paddle
that referenced
this pull request
Oct 24, 2023
…addlePaddle#58223) * remove_diag_embed_to_creation * remove_diag_embed_to_creation * Update __init__.py * Incompatible upgrade * fix_bugs * add_deprecated * remove diag_embed from __all__
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 26, 2023
…addlePaddle#58223) * remove_diag_embed_to_creation * remove_diag_embed_to_creation * Update __init__.py * Incompatible upgrade * fix_bugs * add_deprecated * remove diag_embed from __all__
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…addlePaddle#58223) * remove_diag_embed_to_creation * remove_diag_embed_to_creation * Update __init__.py * Incompatible upgrade * fix_bugs * add_deprecated * remove diag_embed from __all__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
Pcard-73263
diag_embed是一种使用频率较高的创建方法，需要支持Paddle/Tensor.diag_embed的调用形式。简单实现办法是在tensor_match_methods.py文件中import该函数将其作为Tensor类方法，但此时会遇到import循环依赖的问题（解决成本较高，也无必要）。目前与其属于同类的的diag、diagflat、diagonal API被放置在paddle/tensor/creation.py中。现在将diag_embed函数的实现迁移到同类API所在的creation.py文件中，而在原实现位置调用，并做废弃警告处理。