[CustomDevice] use CommContextManager to create xccl comm #57957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ronny1996
force-pushed
the
comm_init_op
branch
4 times, most recently
from
a2dbd4e
to
fada7ff
Compare
ronny1996
force-pushed
the
comm_init_op
branch
from
fada7ff
to
48302b0
Compare
hitywt
reviewed
Oct 10, 2023
| auto store = phi::distributed::CreateOrGetGlobalTCPStore(); | ||
| if (!phi::distributed::CommContextManager::GetInstance().Has( | ||
| std::to_string(rid))) { | ||
| phi::distributed::CommContextManager::CreateXCCLCommContext( |
There was a problem hiding this comment.
这里看下是否需要兼容新旧通信库吧，nccl里是通过FLAGS_dynamic_static_unified_comm这个Flags判断可以做新旧通信库的切换。
124-127的判断develop分支已经更新了，这个pr好像没有提示冲突，可以手动更新下develop，防止覆盖回去了。
(当前flags的判断有问题)
There was a problem hiding this comment.
custom deivce不需要兼容旧通信库了
Frida-a
pushed a commit
to Frida-a/Paddle
that referenced
this pull request
Oct 14, 2023
jiahy0825
pushed a commit
to jiahy0825/Paddle
that referenced
this pull request
Oct 16, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
use CommContextManager to create & get xccl comm