Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.8】add api hypot & hypot_ #57295

Merged
merged 12 commits into from
Oct 18, 2023
Merged

【Hackathon No.8】add api hypot & hypot_ #57295

merged 12 commits into from
Oct 18, 2023

Conversation

llyyxx0413
Copy link
Contributor

@llyyxx0413 llyyxx0413 commented Sep 13, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Description

ADD API hypot & hypot_
RFC：PaddlePaddle/community#626
docs: PaddlePaddle/docs#6230

@paddle-bot
Copy link

paddle-bot bot commented Sep 13, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paddle-bot paddle-bot bot added the contributor External developers label Sep 13, 2023
@Ligoml Ligoml mentioned this pull request Sep 13, 2023
Open
@luotao1 luotao1 self-assigned this Sep 14, 2023
lxd-cumt
lxd-cumt reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@lxd-cumt lxd-cumt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix RuntimeError of test_backward_error in test_inplace.py(TestDygraphInplaceHypot)

@lxd-cumt
Copy link
Contributor

lxd-cumt commented Sep 18, 2023 •
edited
Loading

please run pre-commit for codestyle check

@llyyxx0413
Copy link
Contributor Author

@lxd-cumt 可以帮忙重新跑一下gpups这个吗，我看报错是Timeout，应该不是我这个pr引发的

@lxd-cumt
Copy link
Contributor

@lxd-cumt 可以帮忙重新跑一下gpups这个吗，我看报错是Timeout，应该不是我这个pr引发的

done

lxd-cumt
lxd-cumt approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@lxd-cumt lxd-cumt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llyyxx0413 please resolve conflicts in python/paddle/__init__.py, someone modified the above file and merged

@luotao1
Copy link
Contributor

luotao1 commented Sep 25, 2023

@llyyxx0413 请补充下中文文档

@lxd-cumt lxd-cumt self-requested a review September 25, 2023 08:56
@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Sep 27, 2023

Sorry to inform you that ff8085e's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

jeff41404
jeff41404 reviewed Sep 28, 2023
View reviewed changes
python/paddle/tensor/math.py
return out


def hypot_(x, y, name=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inplace API should be with decorator of @inplace_apis_in_dygraph_only

@luotao1
Copy link
Contributor

luotao1 commented Oct 9, 2023

@llyyxx0413 请解决下冲突

jeff41404
jeff41404 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs. 请补充对应的中文文档

lxd-cumt
lxd-cumt approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@lxd-cumt lxd-cumt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Patrick-Star125 Patrick-Star125 mentioned this pull request Oct 12, 2023
Merged
2 tasks
@luotao1
Copy link
Contributor

luotao1 commented Oct 17, 2023

@llyyxx0413 请尽快提交下中文文档

@llyyxx0413
Copy link
Contributor Author

@llyyxx0413 请尽快提交下中文文档

已加，更新在Description

@luotao1 luotao1 merged commit d392526 into PaddlePaddle:develop Oct 18, 2023
27 checks passed
@luotao1
Copy link
Contributor

luotao1 commented Oct 18, 2023

hi, @llyyxx0413

  • 非常感谢你对飞桨框架的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献，详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣，请发送邮件至 ext_paddle_oss@baidu.com，我们会邀请你加入~

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Oct 18, 2023

Sorry to inform you that 7434f2e's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

hitywt pushed a commit to hitywt/Paddle that referenced this pull request Oct 24, 2023
@llyyxx0413 @hitywt
【Hackathon No.8】add api hypot & hypot_ (PaddlePaddle#57295)
65c8246
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Oct 26, 2023
@llyyxx0413 @jiahy0825
【Hackathon No.8】add api hypot & hypot_ (PaddlePaddle#57295)
04fa817
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@llyyxx0413
【Hackathon No.8】add api hypot & hypot_ (PaddlePaddle#57295)
86726d5
@luotao1
Copy link
Contributor

luotao1 commented Dec 26, 2023

hi, @llyyxx0413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff41404 jeff41404 jeff41404 approved these changes

@tianshuo78520a tianshuo78520a tianshuo78520a approved these changes

@lxd-cumt lxd-cumt lxd-cumt approved these changes

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

Assignees

@luotao1 luotao1

@jeff41404 jeff41404

@lxd-cumt lxd-cumt

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@llyyxx0413 @CLAassistant @lxd-cumt @luotao1 @jeff41404 @tianshuo78520a @sunzhongkai588