support custom vjp trait #57106
Merged
support custom vjp trait #57106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… custom_vjp_trait
… custom_vjp_trait
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
PR描述最好可以贴一个生成出来的例子，比如gelu |
|
|
||
| namespace paddle { | ||
| namespace dialect { | ||
| class CustomVjpTrait : public ir::OpTraitBase<CustomVjpTrait> { |
done，thx |
… custom_vjp_trait
… custom_vjp_trait
… custom_vjp_trait
Charles-hit
previously approved these changes
Sep 11, 2023
| return newir_program | ||
|
|
||
|
|
||
| class TestCustomVjpTrait(unittest.TestCase): |
zhangbo9674
reviewed
Sep 11, 2023
| # import from paddle/fluid/primitive/code_gen/gen.py | ||
| sys.path.append( | ||
| str(pathlib.Path(__file__).resolve().parents[3] / 'primitive/codegen') | ||
| ) |
There was a problem hiding this comment.
当前缺少__init__.py，使用相对路径的话需要新增才可以；
python代码规范里面也提到：
Absolute imports are recommended, as they are usually more readable and tend to be better behaved
(or at least give better error messages) if the import system is incorrectly configured .所以使用了绝对路径。
zhangbo9674
previously approved these changes
Sep 11, 2023
… opt_custom_vjp_trait
… opt_custom_vjp_trait
lxd-cumt
dismissed stale reviews from zhangbo9674 and Charles-hit
via
1925e3f
cyber-pioneer
approved these changes
Sep 13, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* test prim custom vjp in New IR * add a new CustomVjpTrait to represent whether an op has custom vjp * add has_custom_vjp_op_list to represent ops that have custom vjp * parse has_custom_vjp_op_list and autogen CustomVjpTrait for those ops * add pybind to support checking whether an op has custom vjp in python level * add test * add test for add op custom vjp * add pybind to support checking whether an op has custom vjp in python level * fix bugs * polish code * fix bugs * generate custom_vjp trait based on op list from gen.py * delete has_custom_vjp_op_list * fix bugs * use currently defined list CUSTOM_VJP and VJP_COMPS rather than define new list * fix ctest * fix bugs * divide vjp into prim_vjp and custom vjp * add code comments * add code comments * polish codes * polish code comments * polish codes * fix bugs * add code comments * fix bugs * add custom vjp trait support in new folder * fix bugs * add another example for unit testing * fix bugs --------- Co-authored-by: cyber-pioneer <chenzhuo@tju.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
add custom_vjp trait to support checking whether an op has custom vjp
For example, gelu op has custom vjp rules and is added into custom_vjp list, as follows,
Therefore, for gelu op, CustomVjpTrait is automatically added into it, as follows,
Finally, when calling has_custom_vjp(gelu_op), it will return True, representing that the custom vjp rules for gelu are currently defined.
Pcard-66975