[IR] Support multi-thread run && delete unused code of new_ir interpreter #56148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangbo9674
changed the title
From00
approved these changes
Aug 14, 2023
Aurelius84
approved these changes
Aug 14, 2023
| @@ -107,6 +101,12 @@ class InterpreterBaseImpl { | |||
|
|
|||
| virtual const interpreter::StreamAnalyzer& GetStreamAnalyzer() const = 0; | |||
|
|
|||
| virtual const interpreter::NewIrDependencyBuilder& GetNewIrDependencyBuilder() | |||
There was a problem hiding this comment.
基类里为什么要包括具体类相关的接口？这样是不是就不符合抽象的目的了呀？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
支持多线程调度执行
删除new_ir interpreter中的无用代码
Other
Pcard-67164