【inplace api】Batch add inplace api gt_, ge_, lt_, le_, eq_, not_equal_, logical_and_, logical_or_, logical_xor_, logical_not_, divide_, floor_divide_, bitwise_and_ , bitwise_or_, bitwise_xor_, bitwise_not_ #55509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… batch_add_inplace_api_2
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
Sorry to inform you that fc4e297's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
GGBond8488
force-pushed
the
batch_add_inplace_api_2
branch
from
28d8829
to
066b96f
Compare
GGBond8488
changed the title
This reverts commit c822064.
chenwhql
reviewed
Aug 23, 2023
paddle/phi/core/meta_tensor.h
Outdated
| @@ -86,6 +86,8 @@ class MetaTensor { | |||
| // and it will be deleted in the future. | |||
| virtual bool is_tensor_array() const; | |||
|
|
|||
| virtual TensorBase* tensor() const; | |||
There was a problem hiding this comment.
MetaTensor用于Meta推导，需要隔离数据访问，以避免开发时加trick在静态推导功能中操作tensor data，这是之前fluid设计的问题，所以原先是有意不增加访问tensor的接口的，现在也不建议增加
paddle/phi/infermeta/binary.cc
Outdated
| @@ -380,8 +380,9 @@ void CompareRawInferMeta(const MetaTensor& x, | |||
| out->set_dims(make_ddim(out_dims_array)); | |||
| out->share_lod(x); | |||
| } | |||
|
|
|||
| out->set_dtype(DataType::BOOL); | |||
| if (out->tensor() == nullptr || out->tensor() != x.tensor()) { | |||
There was a problem hiding this comment.
- tensor是否为空原先就有方法可以判断
virtual bool operator!() const { return tensor_ == nullptr; }
- 需要判断是否是同一个tensor的话，可以增加is_same_tensor之类的接口，不建议直接暴露tensor指针
There was a problem hiding this comment.
增加is_same_tensor进行判断
sunzhongkai588
approved these changes
Aug 28, 2023
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
…_, logical_and_, logical_or_, logical_xor_, logical_not_, divide_, floor_divide_, bitwise_and_ , bitwise_or_, bitwise_xor_, bitwise_not_ (PaddlePaddle#55509) * tmp commit * add atan2 * add inplace api * fix error * add inpalce divide * add inplace api * add more inplace * add more inpalce * fix logical_not error * support sinh and cosh in cpu * support asin, acos, atan, asinh, acosh, atanh in cpu * fix typro * fix typro * mv out atan2 ldexp * mv out atan2 ldexp * support sinh and cosh in gpu * support asin, acos, atan, asinh, acosh, atanh in gpu * fix ge error * fix dygraph commpare error * fix dygraph commpare error * check complex in python * fix cast inpalce error * open inplace test * fix ops.yaml error * mv cast inpalce to python * fix coverage ci * add last inplace * fix inplace error * fix cast error * fix error * add nan_to_num_ * fix typro * fix sparse cast error * remove gpu 4 * fix static cast error * tmp commit * add atan2 * add inplace api * fix error * add inpalce divide * add inplace api * add more inplace * add more inpalce * fix logical_not error * fix typro * fix typro * mv out atan2 ldexp * mv out atan2 ldexp * fix ge error * fix dygraph commpare error * fix dygraph commpare error * fix cast inpalce error * open inplace test * fix ops.yaml error * mv cast inpalce to python * fix coverage ci * add last inplace * fix inplace error * fix cast error * fix error * add nan_to_num_ * fix typro * fix sparse cast error * remove gpu 4 * fix static cast error * fix cast error * fix * Revert "check complex in python" This reverts commit c822064. * add renorm , fix error * add coverage * fix cumsum inpalce version error * add cast inpalce impl * rm test.log * fix multiply_dyfunction and add multiply_backward test * add and use is_same_tensor * fix typro * fix sone error * fix typro --------- Co-authored-by: Scotty <jmhgchn@gmail.com> Co-authored-by: Scotty <527407973@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
Pcard-72375
batch add inplace api as follow，and these api return tensor's dtype as same as input x
will add inplace api as follow too