Support selected rows new ir #54987
Merged
Support selected rows new ir #54987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
… support_selected_rows_new_ir
…e/Paddle into support_selected_rows_new_ir
phlrain
force-pushed
the
support_selected_rows_new_ir
branch
from
951e173
to
6bf20a2
Compare
… support_selected_rows_new_ir
… support_selected_rows_new_ir
… support_selected_rows_new_ir
… support_selected_rows_new_ir
… support_selected_rows_new_ir
… support_selected_rows_new_ir
zhangbo9674
approved these changes
Jul 11, 2023
Aurelius84
approved these changes
Jul 11, 2023
| return storage()->selected_rows_type_.lod(); | ||
| } | ||
|
|
||
| const size_t& AllocatedSelectedRowsType::offset() const { |
There was a problem hiding this comment.
对于size_t、int、double这种数据类型，直接返回copy就可以，在函数里也是直接传值的
| const phi::DataLayout &layout, | ||
| const phi::LoD &lod, | ||
| size_t offset) { | ||
| dialect::SelectedRowsType dense_tensor_type = |
There was a problem hiding this comment.
Suggested change
| dialect::SelectedRowsType dense_tensor_type = | |
| dialect::SelectedRowsType type = |
这里copy后没有改过来吧？
tianshuo78520a
approved these changes
Jul 11, 2023
raindrops2sea
approved these changes
Jul 12, 2023
cqulilujia
pushed a commit
to cqulilujia/Paddle
that referenced
this pull request
Jul 24, 2023
* refine program translator * fix warning: not override * fix bug * merge new modifications * modify by reviews * resolve conflicts * resolve conflicts * fix * fix * update * support selected rows * update * add selectrows * fix bug * add ut * refine code * refien code * update * update * support selected rows * support selected rows * support dense tensor * remove useless code * polish code * remote standalone executor test --------- Co-authored-by: kangguangli <kangguangli@hotmail.com> Co-authored-by: zhangbo9674 <zhangbo54@baidu.com>
wz1qqx
pushed a commit
to wz1qqx/Paddle
that referenced
this pull request
Jul 31, 2023
* refine program translator * fix warning: not override * fix bug * merge new modifications * modify by reviews * resolve conflicts * resolve conflicts * fix * fix * update * support selected rows * update * add selectrows * fix bug * add ut * refine code * refien code * update * update * support selected rows * support selected rows * support dense tensor * remove useless code * polish code * remote standalone executor test --------- Co-authored-by: kangguangli <kangguangli@hotmail.com> Co-authored-by: zhangbo9674 <zhangbo54@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
新IR 支持selected rows
Others
Pcard-67164