Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IR] add the erase api for region&block. #54844

Merged
merged 1 commit into from
Jun 26, 2023
Merged

[IR] add the erase api for region&block. #54844

merged 1 commit into from
Jun 26, 2023

Conversation

winter-wang
Copy link
Contributor

@winter-wang winter-wang commented Jun 25, 2023 •
edited
Loading

PR types

New features

PR changes

APIs

Description

  • 给ir::Region&ir::Block添加erase接口。
  • 给ir::Value添加ReplaceAllUsesWith接口。
  • 考虑到Operation的GetRegion接口使用频次较高，再不破坏命名规范的情况下，将其重命名为region。
  • 修改ir_program_test 单测，将通过ir::Operation::Create创建算子的使用方式修改为通过ir::Builder::Build接口进行创建。
  • 规范Operation的Destroy函数，要求operation在Destroy的时候，其相应的输出变量必须是use_empty的。
  • 给 ir::OpOperand增加type()接口，返回其类型。

Other

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Jun 25, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@winter-wang winter-wang force-pushed the ir_develop branch 8 times, most recently from 0a66868 to dffa03b Compare June 25, 2023 10:43
jiweibo
jiweibo reviewed Jun 25, 2023
View reviewed changes
paddle/ir/core/value.cc Outdated Show resolved Hide resolved
jiweibo
jiweibo previously approved these changes Jun 25, 2023
View reviewed changes
Copy link
Contributor

@jiweibo jiweibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winter-wang winter-wang requested a review from jiweibo June 25, 2023 11:53
@winter-wang winter-wang merged commit e50266f into PaddlePaddle:develop Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangguangli kangguangli kangguangli approved these changes

@jiweibo jiweibo Awaiting requested review from jiweibo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winter-wang @kangguangli @jiweibo