[Zero-Dim] OpTest support shape check and fix previous case problem #54117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
zhwesky2010
force-pushed
the
0d_optest1
branch
5 times, most recently
from
d332d02
to
99216d0
Compare
zhwesky2010
changed the title
zhwesky2010
changed the title
zhwesky2010
force-pushed
the
0d_optest1
branch
12 times, most recently
from
eb2af01
to
3b83ee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Description
Pcard-66984
进一步增强完善0D Tensor基础设施。由于当前基类OpTest对shape的判断不严格、不规范，导致OP开发时可以轻松绕过0D的shape判断。为了拦截后续OP开发时的0D shape以及维度设置不合理等问题，因此增强基类OpTest对shape的检查功能，同时修复约40个存量单测的问题。
shape判断标准：由于
np.allclose具有自动broadcast功能，所以无任何shape检查功能，例如[3]与[3, 3, 3]对比仍为True；np.testing.assert_allclose虽具有一些shape检查功能，例如[3]与[3, 3, 3]会为False，但不具有0D shape的检查功能，例如[]与[1]仍为True。因此将此处的assert标准统一升级为：先硬性对比shape一致，再np.testing.assert_allclose。