Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon No.61】增加 unfold 算子FP16/BF16单测 #52963

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Apr 16, 2023

PR types

Others

PR changes

Others

Describe

增加 unfold 算子FP16/BF16单测
图片

BF16测试增加init_data,修改初始化参数减少测试时间

@paddle-bot
Copy link

paddle-bot bot commented Apr 16, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

self.input_height,
self.input_width,
]
if self.dtype == np.uint16:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不需要判断了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

)
class TestUnfoldBF16Op(TestUnfoldOp):
# The test is time consuming, modify the parameters to reduce the time
def init_data(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

继承了TestUnfoldOp的话init_data是不是不用再写了,我看你上面也有针对bf16做了修改

Copy link
Contributor Author

@co63oc co63oc Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不修改参数bfloat16测试时间20秒,修改参数减少测试时间,已增加注释
The test is time consuming, modify the parameters to reduce the time

@co63oc
Copy link
Contributor Author

co63oc commented Apr 19, 2023

@luotao1 @ZzSean CI已完成

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZzSean ZzSean merged commit f8823c1 into PaddlePaddle:develop Apr 21, 2023
lijialin03 pushed a commit to lijialin03/Paddle that referenced this pull request Apr 25, 2023
ZzSean pushed a commit to ZzSean/Paddle that referenced this pull request May 5, 2023
@co63oc co63oc deleted the unfold branch May 11, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants