【Hackathon No.64】matmul_with_flatten 算子FP16/BF16单测完善 #52953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZzSean
reviewed
Apr 18, 2023
| self.place, | ||
| ['Y'], | ||
| 'Out', | ||
| max_relative_error=0.5, |
There was a problem hiding this comment.
这个单测中fp16和fp32的max_relative_error设置的都比较大，需要调整确认下默认值是否可以通过测试，同bf16
|
PR-CI-Static-Check 是uint8支持 |
ZzSean
reviewed
Apr 26, 2023
| @@ -114,7 +114,7 @@ def test_check_grad_ignore_y(self): | |||
| @unittest.skipIf( | |||
| not core.is_compiled_with_cuda(), "core is not compiled with CUDA" | |||
| ) | |||
| class TestFP16MulOp1(TestMulOp): | |||
| class TestMulFP16Op1(TestMulOp): | |||
ZzSean
reviewed
Apr 26, 2023
| or not core.is_bfloat16_supported(core.CUDAPlace(0)), | ||
| "core is not compiled with CUDA or not support bfloat16", | ||
| ) | ||
| class TestMulBF16Op(OpTest): |
There was a problem hiding this comment.
已修改，TestMulBF16Op2 check_grad需要设置max_relative_error=0.2
ZzSean
reviewed
Apr 28, 2023
| self.place, | ||
| ['Y'], | ||
| 'Out', | ||
| max_relative_error=0.2, |
There was a problem hiding this comment.
看结果差的有点多，建议调大numeric_grad_delta，可以试试0.05，max_relative_error无需调整
There was a problem hiding this comment.
已修改 numeric_grad_delta为0.02，测试0.01失败
|
@ZzSean 修改CI已完成 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
matmul_with_flatten 算子FP16/BF16单测完善
已有FP16单测和BF16部分支持