add paddle.optimizer.LBFGS API and a modify its test case test=develop #51912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lijialin03
force-pushed
the
develop
branch
4 times, most recently
from
204e708
to
1bcaa95
Compare
lijialin03
changed the title
cxxly
reviewed
Apr 7, 2023
| else: | ||
| numel = 1 | ||
| for dim in p.shape: | ||
| numel *= dim |
There was a problem hiding this comment.
functools.reduce(lambda x, y: x*y, x.shape)
cxxly
reviewed
Apr 7, 2023
| ) | ||
|
|
||
| self.assertRaises(AssertionError, error_func3) | ||
|
|
||
|
|
There was a problem hiding this comment.
move all test case into test_lbfgs.py
|
add @framework.non_static_only for step |
|
copy same version into python/paddle/optimizer/ and add LFBGS into all of init.py |
lijialin03
force-pushed
the
develop
branch
8 times, most recently
from
67190c9
to
29c8145
Compare
|
add deprecated for LBFGS in incubate |
lijialin03
force-pushed
the
develop
branch
3 times, most recently
from
990738b
to
7788333
Compare
lijialin03
changed the title
lijialin03
force-pushed
the
develop
branch
3 times, most recently
from
8bc4260
to
f6111ca
Compare
|
move all test cast into one file t |
cxxly
reviewed
Apr 24, 2023
|
|
||
| import paddle | ||
| from paddle.optimizer import LBFGS | ||
| from paddle.optimizer.lbfgs import _cubic_interpolate, _strong_wolfe |
There was a problem hiding this comment.
import follow pep2 code style, import moudle rather than class/function
lijialin03
changed the title
XieYunshen
approved these changes
Apr 26, 2023
lijialin03
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
Pcard-66961
add paddle.optimizer.LBFGS API
modify numel in _add_grad function to shorten time