[Zero-Dim] fix Tensor.numpy, control whether to hack process to 1D #51757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhwesky2010
force-pushed
the
fix_numpy_0d
branch
from
5fffe1e
to
27586e9
Compare
zhwesky2010
changed the title
zhwesky2010
force-pushed
the
fix_numpy_0d
branch
2 times, most recently
from
af4bde6
to
935aeb6
Compare
zhwesky2010
changed the title
zhwesky2010
force-pushed
the
fix_numpy_0d
branch
from
935aeb6
to
a2d98b7
Compare
zhwesky2010
changed the title
jeff41404
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
Tensor.numpy()的hack为1D的处理，由于框架内部某些API调用了Tensor.numpy()，该hack处理会扩散到框架其他的API，导致一些其他错误的出现，因此增加了一个set_to_1d参数控制是否hack处理，默认下：
Tensor.numpy()会将0D hack处理为1D；Tensor.numpy(False)则没有该hack操作；注意：这部分的hack代码仅保持一定版本，后续下个大版本，会移除这些全部hack代码。