Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Executor] rm Executor._run_parallel #51616

Merged

Conversation

kangguangli
Copy link
Contributor

@kangguangli kangguangli commented Mar 14, 2023

PR types

Others

PR changes

APIs

Describe

The API Executor.Run has multiple internal branches. _run_parallel is one of them which will call the core.ParallelExecutor to execute the program. Since ParallelExecutor will be removed finally, this branch should be removed first to avoid the dependency to ParallelExecutor.

Other

Pcard-67004

@paddle-bot
Copy link

paddle-bot bot commented Mar 14, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kangguangli kangguangli merged commit 2440c98 into PaddlePaddle:develop Mar 16, 2023
@kangguangli kangguangli deleted the rm_executor_run_parallel branch March 16, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants