Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[with_data_parallel][part10] remove with_data_parallel in parallel_executor.py #51369

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

kangguangli
Copy link
Contributor

@kangguangli kangguangli commented Mar 8, 2023

PR types

Others

PR changes

Others

Describe

The api with_data_parallel will be removed after paddle2.5. So its references should be removed at same time.
ParallelExecutor will be deleted in the end but for now we just remove with_data_parallel. This PR also deletes several
unit test cases using ParallelExecutor directly, they seems to run with single gpu since no cmake test property set. So this should be fine.

Other

Pcard-67004

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kangguangli kangguangli merged commit 19001c6 into PaddlePaddle:develop Mar 10, 2023
@kangguangli kangguangli deleted the remove_wdp_in_pe branch March 10, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants