[Prim] Add prod backward composite rule #51238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
|
TestProd8DOp已禁用，因为unqueeze和reshape都不支持8D |
| auto reshape_dim = std::vector<int64_t>(x_dim); | ||
| for (auto i : axis_) { | ||
| reshape_dim[i] = 1; | ||
| } |
There was a problem hiding this comment.
use unsqueezeapi replace
| self.inputs = {'X': np.random.random([]).astype("float64")} | ||
| self.outputs = {'Out': self.inputs['X'].prod()} | ||
| self.attrs = {'dim': [], 'reduce_all': True} | ||
| # reduce doesn't support float64 in cinn. |
There was a problem hiding this comment.
will it raise error when test fp64 with other test(not 0D tensor) in cinn?
There was a problem hiding this comment.
fp64 added in test
|
|
||
|
|
||
| class TestProd8DOp(OpTest): | ||
| def setUp(self): | ||
| self.op_type = "reduce_prod" | ||
| self.python_api = raw_reduce_prod | ||
| self.prim_op_type = "prim" |
There was a problem hiding this comment.
if don't test prim delete this
| @@ -387,6 +393,7 @@ class TestProd6DOp(OpTest): | |||
| def setUp(self): | |||
| self.op_type = "reduce_prod" | |||
| self.python_api = raw_reduce_prod | |||
| self.prim_op_type = "prim" | |||
| self.init_data_type() | |||
| self.inputs = { | |||
| 'X': np.random.random((5, 6, 2, 3, 4, 2)).astype(self.data_type) | |||
There was a problem hiding this comment.
confirm all dtypes has been tested (FP16, FP32,Fp64)
There was a problem hiding this comment.
FP16 is not supported, Fp64 has been added
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
… add_prod_backward_composite_rule
Charles-hit
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe