Support 0d Tensor in ConditionalBlockOp #49842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Jan 16, 2023
zhwesky2010
reviewed
Jan 16, 2023
| @@ -384,8 +384,10 @@ class ConditionalBlockGradOp : public ConditionalOp { | |||
| if (!input_tensor.IsInitialized() || input_tensor.numel() == 0) { | |||
| return; | |||
| } | |||
| if (!input_tensor.meta().is_scalar) { | |||
There was a problem hiding this comment.
这个is_scalar可能用不上。这个判断0D方法用 input_tensor.dims().size()吧
zhhsplendid
changed the title
我后续单独提PR修改文档吧，这样容易用test=document_fix, 跳过一些CI |
经讨论，控制流api不像计算api，直接在test_cond.py单测里检测shape |
zhhsplendid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
Support 0d Tensor in ConditionalBlockOp
append_backward