Support 0D for paddle.sort/argsort #49501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Jan 4, 2023
| @@ -40,6 +42,11 @@ void ArgsortGradKernel(const Context& dev_ctx, | |||
|
|
|||
| if (out_grad.numel() == 0) return; | |||
|
|
|||
| if (rank == 0) { | |||
| phi::funcs::set_constant(dev_ctx, in_grad, 1.0); | |||
There was a problem hiding this comment.
这个是不是得用上面那个函数 int r = xpu::constant( ...
There was a problem hiding this comment.
应该不用，我看有类似文件也是这么直接调用的，比如log_softmax和softmax。
| out1.backward() | ||
| out2.backward() | ||
|
|
||
| self.assertEqual(out1.shape, []) |
There was a problem hiding this comment.
前反向kernel计算逻辑没问题，可以在单测里面再加一下前反向值的检查，因为值比较固定。XPU也一样
DesmonDay
force-pushed
the
support-0D-sort
branch
4 times, most recently
from
77fe4d4
to
31c327f
Compare
DesmonDay
force-pushed
the
support-0D-sort
branch
from
31c327f
to
d486046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
Support 0D for paddle.sort/argsort