[Zero-Dim] Flatten support 0d tensor #49361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhwesky2010
reviewed
Dec 29, 2022
| @@ -712,6 +712,16 @@ def test_scatter_nd(self): | |||
| self.assertEqual(out.numpy()[3], 2) | |||
| self.assertEqual(out.grad.shape, [5]) | |||
|
|
|||
| def test_flatten(self): | |||
| x = paddle.rand([]) | |||
There was a problem hiding this comment.
需要设置x.stop_gradient=False，然后测下反向的shape，不然backward不会求导
| @@ -914,6 +924,21 @@ def test_scatter_nd(self): | |||
| self.assertEqual(res[0].shape, (5,)) | |||
| self.assertEqual(res[0][3], 2) | |||
|
|
|||
| @prog_scope() | |||
| def test_flatten(self): | |||
| x = paddle.full([], 1, 'float32') | |||
There was a problem hiding this comment.
需要设置x.stop_gradient=False，然后测下反向的shape，不然append_backward不会增加反向
zhwesky2010
reviewed
Dec 30, 2022
python/paddle/tensor/manipulation.py
Outdated
| stop_axis = stop_axis + x_dim | ||
| if start_axis > stop_axis: | ||
| raise ValueError("The stop_axis should be larger than stat_axis") | ||
| if x_dim > 0: |
There was a problem hiding this comment.
这样是否会导致没有正确的axis检查，0D时axis必须限制为[0, -1]，其他情况应该报错，可以看下torch的
| @@ -1075,21 +1075,30 @@ void FlattenWithXShapeInferMeta(const MetaTensor& x, | |||
| MetaTensor* xshape) { | |||
| auto x_dims = x.dims(); | |||
| int in_dims_size = x_dims.size(); | |||
|
|
|||
| if (in_dims_size == 0) { | |||
zhwesky2010
previously approved these changes
Jan 5, 2023
|
|
||
| int64_t outer = 1; | ||
| std::vector<int32_t> out_shape; | ||
| out_shape.reserve(in_dims_size - stop_axis + start_axis); | ||
| out_shape.reserve(in_dims_size - stop_axis + start_axis + 1); |
… flatten_support_0dtensor
zhwesky2010
changed the title
zhwesky2010
changed the title
zhwesky2010
approved these changes
Jan 6, 2023
zhwesky2010
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
paddle.flatten支持0D-tensor，其输出为1D-tensor