[Zero-Dim] reshape/reshape_/reverse 0D support #49357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
added 2 commits
December 27, 2022 11:27
zhwesky2010
reviewed
Dec 27, 2022
| self.assertEqual(out.shape, [1]) | ||
| self.assertEqual(out.grad.shape, [1]) | ||
|
|
||
| new_shape = [paddle.to_tensor(-1), paddle.to_tensor(1)] |
There was a problem hiding this comment.
目前paddle.to_tensor还有些bug，会把0D强转为1D，可以把这个改成paddle.full([], -1) paddle.full([], 1)
然后API文档这里用 形状为[]的0D Tensor 比较好
python/paddle/fluid/tests/unittests/xpu/test_zero_dim_tensor_xpu.py
Outdated
Show resolved
Hide resolved
python/paddle/fluid/tests/unittests/xpu/test_zero_dim_tensor_xpu.py
Outdated
Show resolved
Hide resolved
zhwesky2010
reviewed
Dec 28, 2022
python/paddle/tensor/manipulation.py
Outdated
| The data type is ``int32`` . If ``shape`` is a list or tuple, the elements of it should be integers or Tensors with shape [1]. | ||
| If ``shape`` is an Tensor, it should be an 1-D Tensor . | ||
| The data type is ``int32`` . If ``shape`` is a list or tuple, the elements of it should be integers or Tensors with shape []. | ||
| If ``shape`` is an Tensor, it should be an 0-D Tensor . |
There was a problem hiding this comment.
就是如果是list(Tensor)，其每个元素应该是一个标量，就应该支持0D Tensor的list。
如果是Tensor，其应该对应一个list，这个时候还是1D Tensor。
|
API文档这里，建议像目前这样写明白多少D对用户会更清楚些 |
zhwesky2010
approved these changes
Jan 2, 2023
dingjiaweiww
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
add npu/mlu/custom_cpu unittest PaddleCustomDevice#319
reshape 0d tensor doc update docs#5548