[0D Tensor] for dist.scatter and dist.broadcast #48638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
sljlp
force-pushed
the
dim0-scatter
branch
3 times, most recently
from
9afa96f
to
2067ae4
Compare
sljlp
changed the title
ut for nccl
sljlp
changed the title
sljlp
force-pushed
the
dim0-scatter
branch
2 times, most recently
from
7538891
to
19763f4
Compare
This reverts commit e40c51f.
lxsbupt
pushed a commit
to lxsbupt/Paddle
that referenced
this pull request
Dec 17, 2022
zhwesky2010
reviewed
Dec 22, 2022
| @@ -34,6 +34,35 @@ void ConcatKernel(const Context& dev_ctx, | |||
| DenseTensor* out) { | |||
| int64_t axis = axis_scalar.to<int64_t>(); | |||
|
|
|||
| if (UNLIKELY(x[0]->dims().size() == 0)) { | |||
There was a problem hiding this comment.
辛苦这里看下避免对paddle.concat的行为影响
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
Make API distribution.scatter support 0D tensor and add test for nccl
API distribution.broadcat already supports 0D tensor, only add test for nccl