Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes basic dtypes for all_reduce api in eager mode #45440

Merged
merged 6 commits into from
Aug 29, 2022

Conversation

HermitSun
Copy link
Contributor

@HermitSun HermitSun commented Aug 26, 2022

PR types

New features

PR changes

OPs

Describe

This pr completes the basic function of communication framework, support various data types.

  • Supports int8, uint8, bool dtypes for all_reduce in NCCL and GLOO backends.
  • Completes to test all supported dtypes in all_reduce in eager mode.

通信框架功能进一步补全,通信操作支持传输丰富的数据类型。

  • all_reduce操作,支持动态图场景下使用NCCL、GLOO后端进行int8、uint8、bool类型的数据传输。
  • 补充动态图场景下已支持的所有数据类型的all_reduce的测试。
  • 对应文档的中文api修改见Update all_reduce docs & fix typo docs#5206

@paddle-bot
Copy link

paddle-bot bot commented Aug 26, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Aug 26, 2022

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@HermitSun HermitSun changed the title Dev syl allreduce Completes dtypes for all_reduce api in eager mode Aug 26, 2022
@HermitSun HermitSun changed the title Completes dtypes for all_reduce api in eager mode Completes basic dtypes for all_reduce api in eager mode Aug 26, 2022
@HermitSun HermitSun marked this pull request as ready for review August 26, 2022 07:19
Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add support of bool type, should we modify c++ backend?

LiYuRio
LiYuRio previously approved these changes Aug 29, 2022
@HermitSun
Copy link
Contributor Author

To add support of bool type, should we modify c++ backend?

Maybe we have supported bool type in prev pr #44417.

liuTINA0907
liuTINA0907 previously approved these changes Aug 29, 2022
liuTINA0907
liuTINA0907 previously approved these changes Aug 29, 2022
Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gongweibao gongweibao merged commit 7bd02d2 into PaddlePaddle:develop Aug 29, 2022
@HermitSun HermitSun deleted the dev-syl-allreduce branch August 29, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants