Fix custom op attr names size error #44938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
chenwhql
commented
Aug 5, 2022
| @@ -333,8 +333,7 @@ static std::vector<paddle::any> CastAttrsToTragetType( | |||
| src.size())); | |||
| for (size_t i = 0; i < src.size(); i++) { | |||
| size_t end = attrs_names[i].find(": "); | |||
| std::string type_name = | |||
| attrs_names[i].substr(end + 2, attrs_names.size() - end - 2); | |||
There was a problem hiding this comment.
attrs_names.size() should be attrs_names[i].size()
JiabinYang
approved these changes
Aug 8, 2022
| @@ -333,8 +333,7 @@ static std::vector<paddle::any> CastAttrsToTragetType( | |||
| src.size())); | |||
| for (size_t i = 0; i < src.size(); i++) { | |||
| size_t end = attrs_names[i].find(": "); | |||
| std::string type_name = | |||
| attrs_names[i].substr(end + 2, attrs_names.size() - end - 2); | |||
chenwhql
added a commit
to chenwhql/Paddle
that referenced
this pull request
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
Fix custom op attr names size error