Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] release/2.3 elementwise_mul and matmul mkldnn fix #43725

Merged

Conversation

lidanqing-intel
Copy link
Contributor

@lidanqing-intel lidanqing-intel commented Jun 21, 2022

PR types

Bug fixes

PR changes

OPs

Describe

elementwise_mul and matmul mkldnn fix

@lidanqing-intel lidanqing-intel changed the title Release/2.3 fc ernie fix Release/2.3 elementwise_mul and matmul mkldnn fix Jun 21, 2022
@paddle-bot-old paddle-bot-old bot added contributor External developers status: proposed labels Jun 21, 2022
@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@lidanqing-intel lidanqing-intel changed the title Release/2.3 elementwise_mul and matmul mkldnn fix [cherry-pick] release/2.3 elementwise_mul and matmul mkldnn fix Jun 21, 2022
wozna and others added 2 commits June 22, 2022 04:57
…s outputs (PaddlePaddle#43297)

* fix some matmul that X and Y both other ops outputs, do not dequantize the Y.

* fix CI format

* fix according to review
@lidanqing-intel
Copy link
Contributor Author

@jiangjiajun @yeliang2258 Could you please help with the failed CI? I can not see what it is the problem.

@lidanqing-intel
Copy link
Contributor Author

@wozna Please review this PR. Thanks

Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-intel
Copy link
Contributor Author

@yeliang2258 @jiangjiajun @yaomichael The required CI all passed, please review and merge this cherry-pick PR. Thank you!

Another cherry-pick PR is #43750, still passing CIs, I have committed with pre-commit.

Copy link
Collaborator

@jiangjiajun jiangjiajun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yeliang2258 yeliang2258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZeyuChen ZeyuChen merged commit a7e0cde into PaddlePaddle:release/2.3 Jun 23, 2022
@lidanqing-intel lidanqing-intel deleted the release/2.3-fc-ernie-fix branch July 15, 2022 10:07
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants