Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IPU] merge recent changes #42078

Merged
merged 3 commits into from
May 5, 2022
Merged

[IPU] merge recent changes #42078

merged 3 commits into from
May 5, 2022

Conversation

gglin001
Copy link
Contributor

@gglin001 gglin001 commented Apr 21, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

  1. add class NameScopeHelper for adding namescope info
  2. 添加更多 种类优化器状态的映射
  3. 为 IpuStrategy 添加 compilation_progress_logger option 用于输出 编译进度
  4. 部分代码清理和杂项优化

@paddle-bot-old paddle-bot-old bot added contributor External developers status: proposed labels Apr 21, 2022
@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

qili93
qili93 approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 requested a review from XieYunshen April 22, 2022 03:16
@paddle-bot-old
Copy link

paddle-bot-old bot commented May 1, 2022

Sorry to inform you that 73e5a2c's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@gglin001
Copy link
Contributor Author

gglin001 commented May 5, 2022

Hi, 麻烦有空可以 review 下 UT timeout 的修改吗😊 @XieYunshen

ref

2022-05-04 11:54:57 The corresponding lines are as follows:
2022-05-04 11:54:57 python/paddle/fluid/tests/unittests/ipu/CMakeLists.txt
2022-05-04 11:54:57 +    set_tests_properties(test_save_load_ipu PROPERTIES TIMEOUT 600)

@gglin001 gglin001 mentioned this pull request May 5, 2022
Closed
@qili93 qili93 merged commit 6ec89ee into PaddlePaddle:develop May 5, 2022
@gglin001 gglin001 deleted the ipu_commit/misc_changes branch May 5, 2022 12:13
gglin001 added a commit to graphcore/Paddle-fork that referenced this pull request May 8, 2022
@gglin001
[IPU] merge recent changes (PaddlePaddle#42078)
592d5a1 
* merge recent changes

* fix setting pipline
@gglin001 gglin001 mentioned this pull request May 8, 2022
Merged
lanxianghit pushed a commit that referenced this pull request May 9, 2022
@gglin001
[Cherry-pick][IPU] merge recent changes (#42078) (#42582)
1f9b60d 
    add class NameScopeHelper for adding namescope info
    添加更多 种类优化器状态的映射
    为 IpuStrategy 添加 compilation_progress_logger option 用于输出 编译进度
    部分代码清理和杂项优化
@paddle-bot-old paddle-bot-old bot removed the contributor External developers label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qili93 qili93 qili93 approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gglin001 @qili93 @XieYunshen