p_norm transfer to phi kernels #40819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenwhql
reviewed
Mar 22, 2022
zyfncg
reviewed
Mar 23, 2022
paddle/phi/infermeta/backward.cc
Outdated
| @@ -220,6 +220,18 @@ void ScatterGradInferMeta(const MetaTensor& index, | |||
| } | |||
| } | |||
|
|
|||
| void PNormGradInferMeta(const MetaTensor& x, | |||
There was a problem hiding this comment.
这里也不需要包这一层，注册InferShapeFunctor的时候直接用GeneralUnaryGradInferMeta就行
paddle/phi/infermeta/unary.h
Outdated
| @@ -66,6 +66,14 @@ void CumsumInferMeta(const MetaTensor& x, | |||
| bool reverse, | |||
| MetaTensor* out); | |||
|
|
|||
| void PNormInferMeta(const MetaTensor& x, | |||
paddle/phi/infermeta/unary.cc
Outdated
| @@ -190,6 +190,63 @@ void CumsumInferMeta(const MetaTensor& x, | |||
| out->share_lod(x); | |||
| } | |||
|
|
|||
| void PNormInferMeta(const MetaTensor& x, | |||
这个op在normalize中使用，有benchmark脚本 |
MingMingShangTian
approved these changes
Mar 24, 2022
zyfncg
approved these changes
Mar 24, 2022
YuanRisheng
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
p_norm transfer to phi kernels