[Eager] publish python c api for eager #37550
Conversation
|
Thanks for your contribution! |
… eager_python_c_api
… eager_python_c_api
| #include "paddle/pten/core/convert_utils.h" | ||
| #include "paddle/pten/core/dense_tensor.h" | ||
| #include "paddle/pten/include/core.h" | ||
| #pragma GCC diagnostic ignored "-Wwrite-strings" |
There was a problem hiding this comment.
这里是因为CI编译会报编译错误：
eager_properties.cc:143:50: error: ISO C++ forbids converting a string constant to 'char*' [-Werror=write-strings]
cmake/flags.cmake
Outdated
| @@ -141,6 +141,7 @@ set(COMMON_FLAGS | |||
| -Wno-unused-parameter | |||
| -Wno-unused-function | |||
| -Wno-error=literal-suffix | |||
| -Wno-error=missing-field-initializers | |||
There was a problem hiding this comment.
Why this, remove it if not necessary.
| #include "paddle/pten/include/core.h" | ||
|
|
||
| namespace paddle { | ||
| namespace pybind { |
There was a problem hiding this comment.
How about change these to a new namespace, since we will have serval api as same as imperative.
There was a problem hiding this comment.
我觉得还是这个namespace更合理，所有向python暴露的代码都放在pybind文件夹下，所有代码均用pybind namespace。
| #include "pybind11/stl.h" | ||
|
|
||
| namespace paddle { | ||
| namespace pybind { |
| PyObject* arr_; | ||
| }; | ||
|
|
||
| static inline PyObject* eager_api_numpy_to_tensor( |
| return res; | ||
| } | ||
|
|
||
| class EagerNumpyAllocation : public paddle::memory::allocation::Allocation { |
There was a problem hiding this comment.
Plz rearrange all helper class and function to above and list all api implements below
|
|
||
| setattr(core.eager.EagerTensor, "__str__", __str__) | ||
|
|
||
| # for method_name, method in (("__str__", __str__), ("__name__", "Tensor")): |
| self.check_to_tesnsor_and_numpy('complex128') | ||
|
|
||
|
|
||
| class EagerTensorPropertiesTestCase(unittest.TestCase): |
翔实地描述一下。 |
* refine a test case, test=develop * publish python c api for eager, test=develop * revert modify about test_allclose_layer.py, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * delete numpy includes, use pybind11 numpy.h, test=develop * refine, test=develop * refine, test=develop * refine, test=develop * suport eager error msg, and add grad test case, test=develop * refine, test=develop * refine, test=develop
PR types
New features
PR changes
Others
Describe
本PR是Eager（动态图重构项目）从C++端向Python端暴露接口的首个PR，主要提交内容如下：