Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【cherry-pick】Setitem support passing stop_gradient from value to tensor (#37023) #37028

Merged

Conversation

zyfncg
Copy link
Contributor

@zyfncg zyfncg commented Nov 8, 2021

PR types

Bug fixes

PR changes

OPs

Describe

Fix issue:36902

Before this PR:

a = paddle.rand(shape=[1,4])
b = paddle.rand(shape=[1,4])
a.stop_gradient = False
b.stop_gradient = False

d = paddle.zeros((4, 4))
print(d.stop_gradient)  # True
c = a/b
d[0, :] = a/b

print(c.stop_gradient)  # False
print('Is d requires grad: ', not d.stop_gradient)  # Is d requires grad:  False

Now:

a = paddle.rand(shape=[1,4])
b = paddle.rand(shape=[1,4])
a.stop_gradient = False
b.stop_gradient = False

d = paddle.zeros((4, 4))
print(d.stop_gradient)  # True
c = a/b
d[0, :] = a/b

print(c.stop_gradient)  # False
print('Is d requires grad: ', not d.stop_gradient)  # Is d requires grad:  True

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 8, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@MingMingShangTian MingMingShangTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanxianghit lanxianghit merged commit 76cab75 into PaddlePaddle:release/2.2 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants