Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support int32 and int64 kernel for clip operator #32373

Merged
merged 1 commit into from
Apr 22, 2021
Merged

support int32 and int64 kernel for clip operator #32373

merged 1 commit into from
Apr 22, 2021

Conversation

wuyefeilin
Copy link
Contributor

PR types

Function optimization

PR changes

OPs

Describe

clip支持int32和int64 kernel

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Avin0323
Avin0323 previously approved these changes Apr 20, 2021
Copy link
Contributor

@Avin0323 Avin0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for OP-benchmark-CI

TCChenlong
TCChenlong previously approved these changes Apr 21, 2021
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for API Doc
TODO:update Chinese API Doc

wawltor
wawltor previously approved these changes Apr 21, 2021
with shape [1] and type ``int32``, ``float32``, ``float64``.
max (float32|Tensor): The upper bound with type ``float32`` or a ``Tensor``
max (float32|int|Tensor): The upper bound with type ``float32``, ``int`` or a ``Tensor``
with shape [1] and type ``int32``, ``float32``, ``float64``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

float32 -> float

max = fmax if max is None else max
min = min_ if min is None else min
max = max_ if max is None else max
print('input min max value: ', min, max)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除print

@wuyefeilin wuyefeilin dismissed stale reviews from wawltor, TCChenlong, and Avin0323 via 4bc92fc April 21, 2021 07:08
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit c332828 into PaddlePaddle:develop Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants