delete AllocatorFacade destructor #18606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seiriosPlus
changed the title
sneaxiy
reviewed
Jul 12, 2019
| @@ -295,7 +295,7 @@ class AllocatorFacadePrivate { | |||
|
|
|||
| // Pimpl. Make interface clean. | |||
| AllocatorFacade::AllocatorFacade() : m_(new AllocatorFacadePrivate()) {} | |||
| AllocatorFacade::~AllocatorFacade() { delete m_; } | |||
| AllocatorFacade::~AllocatorFacade() {} | |||
There was a problem hiding this comment.
Please add some comments on the reason why we remove delete m_.
wozna
pushed a commit
to wozna/Paddle
that referenced
this pull request
Jul 22, 2019
* delete m, test=develop
seiriosPlus
added a commit
to seiriosPlus/Paddle
that referenced
this pull request
Aug 28, 2019
* delete m, test=develop
seiriosPlus
added a commit
that referenced
this pull request
Aug 29, 2019
* fix bug in Class MultiSlotDataGenerator's function _gen_str, test=develop (#18222) * fix some bug when merge sparse embedding parameters, test=develop (#18223) * fix communicator with pyreader (#18350) * delete AllocatorFacade destructor (#18606) * fix distribute transpiler GRPC error code 4, RPC Deadline (#18984) * merge pr #18441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复#17900中， 由于python/c++析构顺序导致的Segmentation fault.