-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Review] Update stage 2 to Julia #351
Conversation
@chusloj FYI, I refactored some of the Python code behind this in #324 to avoid code duplication. Happy to do that after you're done, though I might ask you for some tips as I haven't worked with Julia before, or if it's easy for you to do while you're in here feel free. Also some of the multi-line statements look like they need some extra indentation to align. |
The code for the Julia solver update is finished. Overview:
UPDATE: @andersonfrailey and myself have confirmed that the reproducibility issue does not pop up anymore, but for the issue to be solved, |
Just to put this in there before I forget, we need to install three Julia packages to run the new stage 2 scripts: |
A Julia environment now exists as a Julia --project={env_path} solver.jl in |
After comparing Tax-Calculator projections from the PUF and CPS weights before and after the Julia solver was implemented, results show that projections don't change. If this seems irregular, note that the solver Julia is using right now ( |
Thanks for working on this, @chusloj. I'm going to leave this PR open for a couple days to allow feedback from others. |
If there are no objections, I'll merge this PR at COB today. |
This PR addresses #348 . This will replace both the CPS and PUF stage2 Python files with Julia files and change
README
files accordingly.