-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nu06 Variable to PUF #329
Conversation
Thanks, @andersonfrailey!
I'm inclined to keep both in puf.csv until we add (cc @MaxGhenis). |
I'm not aware of major policies using |
@andersonfrailey, are you happy with this approach:
|
@MattHJensen Yep this is good with me. I'll update the PR accordingly. |
Added nu05 back to the PUF in the latest commit |
@andersonfrailey, could you update me on the status of this PR when you have an opportunity? I apologize if it was ready to be merged before and requires an update now. |
@MattHJensen, ready to go! There doesn't seem to be any conflicts. We still can't add |
Now that #314 is merged, this will be ready to go when I get the merge conflicts resolved |
Fixed up the merge conflicts. Totally removed |
Doesn't look like there are any more comments so merging |
This PR changes the
nu05
variable tonu06
inpuf.csv
. As of yet, we can't make this update in the CPS file, but as @MattHJensen pointed out in issue #311, there are users who would like to see this added to the PUF as a first step.Before merging, I think we should establish what to do with the
nu05
variable in the CPS file. I'm inclined to either a) remove it or b) actually keep it in the PUF so that we will havenu05
andnu06
. I'm open to other's suggestions on how to move forward from here.Also, I found that when I created the new PUF file, the
e19200
variable sum increased by 1. This is probably just rounding error, but I think it's still odd that this has happened.