Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enable tests in ci #16

Merged
merged 54 commits into from
Apr 24, 2023
Merged

test: enable tests in ci #16

merged 54 commits into from
Apr 24, 2023

Conversation

muchvo
Copy link
Collaborator

@muchvo muchvo commented Feb 12, 2023 •
edited by zmsn-2077
Loading

Description

  1. Enable tests in ci.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

XuehaiPan
XuehaiPan reviewed Feb 12, 2023
View reviewed changes
tests/test_env.py Outdated Show resolved Hide resolved
@friedmainfunction friedmainfunction marked this pull request as draft February 12, 2023 16:47
zmsn-2077
zmsn-2077 previously approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After careful review, I agree with these changes.

@zmsn-2077
Copy link
Member

Need to rebase.

@muchvo
Copy link
Collaborator Author

muchvo commented Apr 14, 2023

Need to rebase.

got it

zmsn-2077
zmsn-2077 previously approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

XuehaiPan
XuehaiPan reviewed Apr 17, 2023
View reviewed changes
tests/test_env.py Outdated Show resolved Hide resolved
@XuehaiPan XuehaiPan added this to the 0.3.0 milestone Apr 17, 2023
@XuehaiPan XuehaiPan added the enhancement New feature or request label Apr 17, 2023
@muchvo @XuehaiPan
Update .github/workflows/tests.yml
4531ab7 
Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
@muchvo @XuehaiPan
Update tests/test_env.py
d3ea47a 
Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
@zmsn-2077 zmsn-2077 added the dependencies Something related to package dependencies label Apr 18, 2023
zmsn-2077
zmsn-2077 previously approved these changes Apr 18, 2023
View reviewed changes
Gaiejj
Gaiejj previously approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@muchvo muchvo dismissed stale reviews from Gaiejj and zmsn-2077 via adbd6f3 April 19, 2023 07:07
@muchvo muchvo merged commit 0be3cae into PKU-Alignment:main Apr 24, 2023
@muchvo muchvo deleted the ci_test branch April 24, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuehaiPan XuehaiPan XuehaiPan approved these changes

@zmsn-2077 zmsn-2077 zmsn-2077 approved these changes

@Gaiejj Gaiejj Gaiejj left review comments

Assignees
No one assigned
Labels
dependencies Something related to package dependencies enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@muchvo @zmsn-2077 @XuehaiPan @Gaiejj