Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up: delete unused target variants module #47

Open
wants to merge 2 commits into
base: fix-nonadditive
Choose a base branch
from

Conversation

nebfield
Copy link
Member

@nebfield nebfield commented Sep 9, 2024

These library classes and functions are no longer imported or used anywhere, so should probably be deleted

The last time they were called was prior to #22 being merged

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (71f2f90) to head (13cefc2).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           fix-nonadditive      #47      +/-   ##
===================================================
+ Coverage            89.18%   89.19%   +0.01%     
===================================================
  Files                   40       39       -1     
  Lines                 2320     2249      -71     
===================================================
- Hits                  2069     2006      -63     
+ Misses                 251      243       -8     
Flag Coverage Δ
pgscatalog.core 90.25% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nebfield nebfield marked this pull request as ready for review September 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant