-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translate bytecode ops #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 👍
逻辑相关的op转换还有点问题,在排查中 |
是说位操作吧,由于目前所有 frame 的 code 都是原样执行,所以只要有 frame 的函数都会进入 Translator 对于 Paddle 的 EagerTensor 来说, 目前的话,我觉得把 C++ 端实现的 magic funcs 支持就可以了( https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/fluid/dygraph/math_op_patch.py#L458 ) |
is << >>等也存在问题,主要是因为 b = a << 2 此处2不会被加入stack中,会导致node的参数错误,或是stack为空报错 print('ababa') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
我们先合入吧。
接下来咱们再整理一下下后续的TODO,另外再提PR。
No description provided.