Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port cdat_info functions #1103

Merged
merged 24 commits into from
Aug 14, 2024
Merged

Port cdat_info functions #1103

merged 24 commits into from
Aug 14, 2024

Conversation

acordonez
Copy link
Collaborator

@acordonez acordonez commented Jul 2, 2024 •
edited

  1. cdat_info.download_sample_data_files has been copied to base.io with some minor changes. The Demo 0 notebook and Demo 6 notebook have been run with the updated import statement.
  2. cdat_info.provenance.generateProvenance and dependencies have been copied to base.io with some minor changes. I have combined it with the changes that are currently in base.generateProvenance such as the added packages to record. I have removed references to packages like VCS that are no longer PMP dependencies.

I have not copied cdat_info.get_sampledata_path() because there are no references to it in the PMP production code.

I have removed all references to cdat_info except in deprecated code.

Closes #1003

@acordonez
Copy link
Collaborator Author

Still waiting on ENSO notebook testing.

@acordonez
Copy link
Collaborator Author

Still waiting on ENSO notebook testing.

Pushed update to ENSO notebook. Now need to debug testing failure.

@acordonez
Copy link
Collaborator Author

The line throwing the error (106: author = msg["Author"]) is not found in recent versions of esmpy/init.py. I'm trying to figure out what version is getting pulled by the test suite and if there's a way to grab a newer version.
This esmpy issue provides some additional background: esmf-org/esmf#140

@acordonez
Copy link
Collaborator Author

acordonez commented Jul 11, 2024 •
edited

Tried pinning the esmpy version to > 8.4.2 but that caused a failure in setting up the test conda environment. Now trying to pin importlib_metadata to an older version that does not raise the error (reference).

@acordonez
Copy link
Collaborator Author

It looks like pinning the importlib_metadata version actually got the test to run successfully. This pin should be removed when we're able to figure out a dev environment that uses a newer esmpy version.

@acordonez acordonez self-assigned this Jul 29, 2024
This was referenced Aug 1, 2024
Open
Merged
@acordonez
Copy link
Collaborator Author

I've created a fix for the build problems in #1107.

@acordonez acordonez merged commit 4f1c8f4 into main Aug 14, 2024
5 checks passed
@acordonez acordonez deleted the 1003_ao_cdat branch August 14, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lee1043 lee1043 lee1043 approved these changes

Assignees

@acordonez acordonez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Port cdat_info dependencies to PMP
2 participants
@acordonez @lee1043