Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Port cdat_info dependencies to PMP #1003

Closed
acordonez opened this issue Nov 29, 2023 · 0 comments · Fixed by #1103
Closed

[Feature]: Port cdat_info dependencies to PMP #1003

acordonez opened this issue Nov 29, 2023 · 0 comments · Fixed by #1103

Comments

@acordonez
Copy link
Collaborator

Is your feature request related to a problem?

PMP is currently dependent on cdat_info, which has been sunsetted. We need an alternative to using cdat_info for downloading sample data files and generating provenance.

Here are references to where the PMP calls cdat_info:

download_sample_data_files: PMP ex1, ex2, source
generate_provenance: PMP, source
get_sampledata_path: PMP (deprecated but listing for completion), source

Describe the solution you'd like

cdat_info uses the same license as the PMP (BSD-3 Clause), a license which would let us reuse cdat_info source code. I propose copying over the download_sample_data_files and generate_provenance functions to the PMP. They may need some changes to integrate with the PMP, but this looks reasonable to me.

Describe alternatives you've considered

We could look for other libraries or build custom solutions from scratch, but those would both likely take more time and effort.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant