Fix multiple bodies in JsTree output #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there was no test coverage for the output of multiple json-tree modules. To address this, this commit adds a new test that parses two modules and compares their combined output against the old expected output. This provides more comprehensive testing and ensures that the json-tree modules are correctly processing multiple inputs. JIRA:LIGHTY-221 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
ihrasko
force-pushed
the
mainJsTreeFix
branch
from
6169d50
to
d6a8589
Compare
Added test case for generating HTML file from multiple modules to identify the issue with multiple <body> tags. The test asserts that the file contains the expected modules, verifies that there is only one <body> tag, and checks if the output matches the expected HTML file. JIRA: LIGHTY-182 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ensure JsTree output contains a single body element, resolving the issue of multiple bodies in the generated HTML file. JIRA: LIGHTY-128 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
Since we have changed the logic of JsTree, the expected output for deviations needs to be changed. JIRA: LIGHTY-128 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
ihrasko
force-pushed
the
mainJsTreeFix
branch
from
d6a8589
to
4829bce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure JsTree output contains a single body element, resolving the
issue of multiple bodies in the generated HTML file.
JIRA: LIGHTY-128