upgraded docker login action to prevent problems with soon-to-be deprecated github workflow commands #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes warnings from the release action(https://github.com/PANTHEONtech/StoneWork/actions/runs/6313188882):
These warnings would not be warnings anymore and release job would be already broken if github would not postpone the deprecation (https://github.blog/changelog/2023-07-24-github-actions-update-on-save-state-and-set-output-commands/).
We are not directly using those commands, but the action that we use for docker login is using it. This tool has already fixed the issues (docker/login-action#158 , @actions/core version bump in https://github.com/docker/login-action/releases/tag/v2.1.0). So using 2.1.0 would probably fix it, but i used the latest 3.0.0.
Testing:
Testing is complicated as it needs to have the change already pushed so that the changed github action can be triggered by some event. Also docker image repository is needed as docker login is involved.
I did testing in my fork. I applied this PR to main. Changed the github action to do only docker login and used my personal github packages as docker image repo (see changes in https://github.com/fgschwan/StoneWork/tree/fix-release-job-warnings, + also created temporal github token for packages access and put token string to repo secret variable available to action). After that i created separate branch (https://github.com/fgschwan/StoneWork/tree/fix-release-job-warnings-test) just to make test commit that trigger the job and i can see that docker login passes successfully.
I didn't want to pollute this repo with such testing, therefore i did the testing in my fork. Anyone can repeat this to verify the change.