Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - Command-line Completion #83

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Update README.md - Command-line Completion #83

merged 1 commit into from
Nov 22, 2021

Conversation

crpb
Copy link
Contributor

@crpb crpb commented Nov 21, 2021

  • Test for bash-completion had the wrong filename if downloaded
    as stated in curl command.
  • Replaced ~ with $HOME because ~ doesn't always work with
    double-quotes.

well, just my 2 cents here....
The Filename I think is safe to say that it should be fixed :-).
And for the ~/, well I often come across problems with those expansions in double-quotes and without them. IMHO $HOME is just a safer bet.

- Test for bash-completion had the wrong filename if downloaded
  as stated in curl command.
- Replaced ~ with $HOME because ~ doesn't always work with
  double-quotes.
Copy link
Owner

@OrkoHunter OrkoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - this makes sense! 🙌

@OrkoHunter OrkoHunter merged commit 20edf98 into OrkoHunter:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants