This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
[Backup] Do not validate Secret for file protocol #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File protocol does not need any authentication, but backup will fail if secret is not set. Fixes #378
|
Hello @AKamyshnikova, |
|
@fdehay Hi! |
|
@fdehay looks good to me. We should test that a regular backup still works as it's not tested here. other than that 👍 |
|
@AKamyshnikova it seems part of this code is already included in the volume mounts PR. Is it because the other PR is branched off of this one ? |
3 tasks
|
@cscetbon Hi! Yes, I just based it on top of this. I could rebase on master the other one when this is merged. |
cscetbon
approved these changes
Dec 10, 2021
Merged
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File protocol does not need any authentication, but backup will
fail if secret is not set.
Check protocol type before validating secret.
Fixes #378