-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download handlers for google drive & node connectors. #76
Conversation
@@ -8,6 +8,7 @@ | |||
"upload-coverage": "cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js", | |||
"test": "rimraf ./.nyc_output ./coverage && cross-env nyc --reporter=lcov --reporter=text mocha --require config/test/mocha-setup.js --recursive src/**/*.spec.js --require ignore-styles", | |||
"start": "cross-env NODE_ENV=development showroom-scan src && babel-node --presets es2015,stage-0 www/index", | |||
"start-wmd": "cross-env NODE_ENV=development showroom-scan src && babel-node --presets es2015,stage-0 win/index-windows", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add it for this PR. @estambakio-sc don't forget find a way to pass env variables on MS Windows and remove this goal!
@@ -28,3 +28,5 @@ client-react/.nyc_output | |||
/client-react/.gh-pages-tmp | |||
/client-react/www/static | |||
/demo/.gh-pages-tmp | |||
|
|||
/client-react/win |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add it for this PR. @estambakio-sc don't forget find a way to pass env variables on MS Windows and remove this goal!
client-react/package.json
Outdated
@@ -97,6 +98,7 @@ | |||
"core-js": "2.5.0", | |||
"filesize": "3.5.11", | |||
"immutable": "3.8.2", | |||
"jszip": "^3.1.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove ^
. We use fixed versions of dependencies.
<div style={{ height: '70vh', minWidth: '320px', flex: '1', marginBottom: '15px' }}> | ||
<FileNavigator | ||
api={_scope.connectors.nodejs_v1.api} | ||
apiOptions={{ | ||
apiRoot: `${window.env.SERVER_URL}/api` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert back to SERVER_URL
env var.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make changes and resolve conflict with master
branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK
According to #66