-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove and upload capabilities nodejs #74
Conversation
# Conflicts: # client-react/src/client/connectors/nodejs_v1/capabilities/upload.js
@@ -0,0 +1,2 @@ | |||
.set-name-dialog { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this CSS class
}; | ||
|
||
export default | ||
class CancelOkDialog extends Component { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename CancelOkDialog
to ConfirmDialog
</div> | ||
|
||
<div className="oc-fm--dialog__horizontal-group oc-fm--dialog__horizontal-group--to-right"> | ||
<button type="button" className="oc-fm--dialog__button oc-fm--dialog__button--default" onClick={onHide}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create handleCancel
method as handleSubmit
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make requested changes.
There are several code-style errors, but eslint is still not enabled on CircleCI, so its not a problem for now. =)
}; | ||
const defaultProps = { | ||
headerText: 'Do you really want to remove the file?', | ||
submitButtonText: 'Ok', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make Ok
uppercase
api.removeResources(apiOptions, selectedResources, { onSuccess, onFail }); | ||
}} | ||
headerText={`Do you really want to remove\n${selectedResources.length > 1 ? `${selectedResources.length} files` : `the file ${selectedResources[0].name}`}?`} | ||
submitButtonText={'Ok'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make Ok
uppercase
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now looks OK.
#18 #21