Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add langchain chatbot #848

Merged
merged 15 commits into from
Jun 9, 2024
Merged

Add langchain chatbot #848

merged 15 commits into from
Jun 9, 2024

Conversation

YanxinLu
Copy link
Contributor

@YanxinLu YanxinLu commented Jun 6, 2024

No description provided.

@YanxinLu YanxinLu closed this Jun 6, 2024
@YanxinLu YanxinLu reopened this Jun 6, 2024
Copy link
Contributor

@research4pan research4pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much! Some changes and questions regarding the PR.

README.md

  • [Style] Better add a runnable example with example files, along with its download script in data/download.sh

contrib/langchain/retrieval_chatbot.py

  • [Question] line 73, 81: I am wondering if splitting documents by a fixed number of char size without overlap is the common approach, since there may be losses near the boundary.
  • [Style] line 173: Better make this chat history file path an argument with a default value of tmp/chat_history.
  • [Style] line 174: 'abc123' better to be other interpretable keywords, or a constant variable with interpretable names.

Copy link
Contributor

@research4pan research4pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍 Some minor points that can improved later

contrib/langchain/README.md

  • [Style] We normally use naming convention like --set_url instead of --set-url.
  • [Style] We can add separated example usages for URL retrieval and text retrieval.

@research4pan research4pan merged commit f7a8196 into OptimalScale:main Jun 9, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants