Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldFail.reverting.withMessage should fail if no string is provided #27

Closed
nventuro opened this issue Apr 22, 2019 · 0 comments · Fixed by #28
Closed

shouldFail.reverting.withMessage should fail if no string is provided #27

nventuro opened this issue Apr 22, 2019 · 0 comments · Fixed by #28
Labels
good first issue Good for newcomers

Comments

@nventuro
Copy link
Contributor

For some reason we forgot to add this restriction, see this comment.
@nventuro nventuro added the good first issue Good for newcomers label Apr 22, 2019
Aniket-Engg added a commit to Aniket-Engg/openzeppelin-test-helpers that referenced this issue Apr 23, 2019
@Aniket-Engg
fixes OpenZeppelin#27
33492d3
@Aniket-Engg Aniket-Engg mentioned this issue Apr 23, 2019
Merged
nventuro pushed a commit that referenced this issue Apr 24, 2019
@Aniket-Engg @nventuro
shouldFail.reverting.withMessage fails if no error string is provided (…
8a2de42 
…#28)

* fixes #27

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
1 participant
@nventuro