Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make padding skip clear in Base64URL encoding #5176

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

ernestognw
Copy link
Member

Fixes N-03

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Aug 29, 2024

⚠️ No Changeset found

Latest commit: 7e04259

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

contracts/utils/Base64.sol Outdated Show resolved Hide resolved
@ernestognw ernestognw requested a review from Amxx September 3, 2024 15:09
@ernestognw ernestognw merged commit dfb3ec3 into OpenZeppelin:master Sep 3, 2024
21 checks passed
@pcaversaccio
Copy link
Contributor

Hmm, I was just reading https://www.rfc-editor.org/rfc/rfc4648#section-4. Standard Base64 includes padding (not strictly enforced tho). I still think OZ should add padding IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants