Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make explicit the validity of the empty set in MerkleProof.sol #5142

Conversation

ernestognw
Copy link
Member

Makes it explicit that users verifying multiproofs should consider that the empty set is valid.
Most implementations do check the validity of the leaves or build them within the contract, which makes it impossible to validate a proof incorrectly.

This is consistent with our no-ops policy

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: 69a8477

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw changed the title Chore/add empty set note merkle proof Make explicit the validity of the empty set in MerkleProof.sol Aug 5, 2024
Copy link
Contributor

@cairoeth cairoeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, would be cherry-picked for 5.1 update?

@ernestognw
Copy link
Member Author

lgtm, would be cherry-picked for 5.1 update?

Yes, I'll pick it up to #5139

@ernestognw ernestognw merged commit bcd4beb into OpenZeppelin:master Aug 7, 2024
25 checks passed
@ernestognw ernestognw added this to the 5.1-after-freeze milestone Aug 7, 2024
ernestognw added a commit to Amxx/openzeppelin-contracts that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants