-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hardhat-exposed to reduce the need for mocks #3666
Conversation
Conflicts: contracts/mocks/StringsMock.sol test/utils/Strings.test.js
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
Inspected the above postinstall scripts and they're safe. |
FYI, just don't underestimate this breaking change - it will break many of my unit tests since I pull some of your (here deleted) mocks via submodules. So once you merge this PR to |
@pcaversaccio Thanks for the heads up. We don't guarantee stability of mocks at all. You should try to remove that dependency if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge this.
pragma solidity ^0.8.0; | ||
|
||
import "../token/ERC20/ERC20.sol"; | ||
import {ERC20} from "../token/ERC20/ERC20.sol"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that is the first time we use this syntax. Is that something we want to be doing more ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. It wasn't a conscious decision, I think I went along with the syntax from a16z/erc4626-tests
.
LGTM |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 OpenZeppelin Contracts Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
PR Checklist