Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add utilities for CrossChain messaging #3183

Merged
merged 42 commits into from
Mar 30, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 10, 2022

Adds a new base contract CrossChainEnabled with instantiations for several chains/bridges, and an extension of access control to have cross chain roles AccessControlCrossChain.

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@frangio frangio changed the title Contracts for CrossChain messaging. Contracts for CrossChain messaging Feb 14, 2022
@OpenZeppelin OpenZeppelin deleted a comment Feb 26, 2022
@OpenZeppelin OpenZeppelin deleted a comment Feb 26, 2022
@frangio frangio mentioned this pull request Mar 21, 2022
1 task
contracts/crosschain/CrossChainEnabled.sol Outdated Show resolved Hide resolved
contracts/crosschain/CrossChainEnabled.sol Outdated Show resolved Hide resolved
contracts/crosschain/CrossChainEnabled.sol Outdated Show resolved Hide resolved
contracts/crosschain/optimism/LibOptimism.sol Outdated Show resolved Hide resolved
contracts/crosschain/arbitrum/LibArbitrumL1.sol Outdated Show resolved Hide resolved
contracts/crosschain/arbitrum/LibArbitrumL2.sol Outdated Show resolved Hide resolved
contracts/crosschain/arbitrum/LibArbitrumL2.sol Outdated Show resolved Hide resolved
contracts/crosschain/amb/LibAMB.sol Show resolved Hide resolved
test/crosschain/CrossChainEnabled.test.js Outdated Show resolved Hide resolved
test/crosschain/CrossChainEnabled.test.js Outdated Show resolved Hide resolved
@Amxx Amxx marked this pull request as ready for review March 25, 2022 10:13
@frangio frangio changed the title Contracts for CrossChain messaging Add utilities for CrossChain messaging Mar 28, 2022
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some test errors, I'm not sure why...

test/utils/structs/DoubleEndedQueue.test.js Outdated Show resolved Hide resolved
@Amxx
Copy link
Collaborator Author

Amxx commented Mar 29, 2022

There's some test errors, I'm not sure why...

{
  expected: 'InvalidCrossChainSender("0xbBBBF9D54eDe0616f77b4932f1e8C049023294cb", "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266")',
  received: 'Returned error: VM Exception while processing transaction: revert with unrecognized return data or custom error'
}

I'm not getting that error locally.

Note that the custom error is recognized when testing Arbitrum and Polygon, but fails for AMB and Optimism ... Also, it always work for error NotCrossChainCall()

@frangio frangio merged commit 668a648 into OpenZeppelin:master Mar 30, 2022
@Amxx Amxx deleted the feature/crosschain branch March 31, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants