Re-enable immutable forwarder in ERC2771Context #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
frangio
reviewed
Oct 18, 2021
Amxx
force-pushed
the
feature/erc2771ForwarderImmutable
branch
from
e460f39
to
ca4ceae
Compare
frangio
reviewed
Nov 15, 2021
frangio
reviewed
Nov 16, 2021
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
|
Note: Missing changelog entry. |
Amxx
force-pushed
the
feature/erc2771ForwarderImmutable
branch
from
eee8b33
to
fdd09db
Compare
frangio
previously approved these changes
Nov 18, 2021
frangio
added
the
on hold
|
I want to wait to merge once we've finished the 4.4 release, because I realized there will be some issues around the immutable variable and the transpiler. |
frangio
removed
the
on hold
|
Should be good now for the transpiler I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2905
PR Checklist